Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filesize Limit #1

Open
joshheinrichs opened this issue Dec 15, 2015 · 2 comments
Open

Filesize Limit #1

joshheinrichs opened this issue Dec 15, 2015 · 2 comments
Labels

Comments

@joshheinrichs
Copy link
Owner

Should add some sort of filesize limitation that can be set inside the config file.

@joshheinrichs
Copy link
Owner Author

youtube-dl has some support for filesize limits, but I think it applies to the video size rather than the song size. This means that you might be not be able to download a 1080p 60fps video since it exceeds the filesize limit, although the resulting audio file is only a few minutes long and doesn't take up much space.

Since only one song is being downloaded at a time, it might be best to have a maximum download size. Having predictable, hard limits on filesize is a good thing, so maximum song size + maximum number of songs would probably be good to have as well.

It also might be nice to have a maximum song length, though I think that's a topic for another issue.

@joshheinrichs
Copy link
Owner Author

I added a video file size limitation as well as download and play queue limits. Still need to address maximum song size and maximum song length.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant