-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Distributions.jl Dependency #44
Comments
Distributions (and indirectly, its 50-something dependencies!) is much too heavy to add here. You can already use any kernel function you want. I'm not sure what you're describing with generalized Pareto. |
|
Sorry, name made me think UnicodePlots.jl depended on Plots.jl.
Being able to overload |
Distributions.jl is a more widely-used interface for working with distributions with more users. Making ASH histograms a subtype of Distributions.jl's density would substantially improve how much of the ecosystem can work with ASH.
Prior to 1.9, I think avoiding the Distributions.jl dependency was a good idea, but now with native code caching, the extra compile time is negligible. In addition, adding Distributions.jl would let the code be simplified substantially in some parts by taking advantage of existing methods from Distributions.jl.
Distributions.jl would also allow for a wider variety of kernels (any Distribution), as well as better density estimates in the tails. (A generalized Pareto Distribution can be fitted to the most extreme observations and used to predict outside the range of observations, rather than taking the ASH estimate directly.)
The text was updated successfully, but these errors were encountered: