Send shift modifier for capital latin characters that we need to bind #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Change looks ok, though I haven't tested. I appreciate the extra comments above the changed code <3 I wonder if isupper() would be a better choice, but I don't know what history lies between X11 keysym/codes and ASCII? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this should address #97 to some extent. I couldn't find an example in github issue that breaks it on my end but I figure someone might.
I've been working on a rust port of xdo and have been making some fixes along the way. Figured I might as well contribute back to the thing I'm porting.
Link to the rust project: https://github.com/neXromancers/oxdo