Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OCHamcrest framework from Carthage #171

Merged
merged 1 commit into from
Aug 13, 2023

Conversation

DivineDominion
Copy link
Contributor

Fixes #169

Requires this additional preparation step:

carthage build --use-xcframeworks

Could add this to a "Run Script" build phase if you prefer.

  • pod lib lint passes
  • carthage build --no-skip-current --use-xcframeworks passes
  • swift build passes

@jonreid
Copy link
Owner

jonreid commented Mar 8, 2023

Thank you for this! Sorry it took me so long to notice.

A problem: It looks like Carthage with Xcode 14.2 currently fails to build OCHamcrest. Have you seen this? Any ideas? hamcrest/OCHamcrest#92

@DivineDominion
Copy link
Contributor Author

@jonreid I don't run into any issues (Xcode 14.3.1) at the moment

@jonreid jonreid merged commit 5f3c402 into jonreid:main Aug 13, 2023
@jonreid
Copy link
Owner

jonreid commented Aug 13, 2023

Now that I finally got OCHamcrest Carthage happy, I'll work on GitHub actions at this level

@jonreid
Copy link
Owner

jonreid commented Aug 13, 2023

My solution was to change Frameworks/gethamcrest to put the xcframework into Carthage/Build

@DivineDominion DivineDominion deleted the use-carthage branch August 14, 2023 05:29
@DivineDominion
Copy link
Contributor Author

Nice! Now I can switch back :)

@jonreid
Copy link
Owner

jonreid commented Aug 17, 2023

I still have a question. I'm starting from no project-local Carthage directory and nothing in ~/Library/Caches/org.carthage.CarthageKit/. It works if I first do carthage update --use-xcframeworks but it seems strange to do an update. Is this what you meant, update instead of build?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building with Carthage fails
2 participants