From f3959e9c422c2fa7968f178a75b42a05311152ca Mon Sep 17 00:00:00 2001 From: Rudi Grinberg Date: Tue, 12 Dec 2023 18:12:55 -0600 Subject: [PATCH] refactor(pkg): add missing loc (#9477) Signed-off-by: Rudi Grinberg --- src/dune_rules/package.ml | 1 + test/blackbox-tests/test-cases/pkg/opam-file-errors.t | 1 + 2 files changed, 2 insertions(+) diff --git a/src/dune_rules/package.ml b/src/dune_rules/package.ml index 1ec6dec7388..9e78533dafc 100644 --- a/src/dune_rules/package.ml +++ b/src/dune_rules/package.ml @@ -695,6 +695,7 @@ let to_local_package t = with | OpamPp.Bad_version (_, message) -> User_error.raise + ~loc:(Loc.in_file (Path.source file)) [ Pp.textf "Unable to parse opam file %s as local dune package." (Path.Source.to_string file) diff --git a/test/blackbox-tests/test-cases/pkg/opam-file-errors.t b/test/blackbox-tests/test-cases/pkg/opam-file-errors.t index cd109bb884d..35fc404c156 100644 --- a/test/blackbox-tests/test-cases/pkg/opam-file-errors.t +++ b/test/blackbox-tests/test-cases/pkg/opam-file-errors.t @@ -10,6 +10,7 @@ Tests for error messages while reading package metadata from opam files Empty files are not allowed as they lack the format version. $ touch x.opam $ dune pkg lock + File "x.opam", line 1, characters 0-0: Error: Unable to parse opam file x.opam as local dune package. unsupported or missing file format version; should be 2.0 or older [1]