Skip to content

Commit d885d49

Browse files
committed
Fix test failure when displaying invisible characters
test/main/emoji-test fails for me at emoji-commit-titles-col-300 because this line is not rendered correctly: 2009-04-06 01:44 +0000 Committer o [master] πŸŒπŸ’§βœ‹πŸ•‹πŸ—‘πŸš€πŸœβ˜€οΈπŸŒ‘πŸŒΆπŸ’―πŸš±β³πŸŒ…πŸŒ‘πŸ˜‘πŸ’‰πŸ˜±πŸ˜ˆπŸ’€πŸ’₯πŸŒ›πŸŒ™πŸ­πŸ’₯πŸšΆπŸ»γ€°πŸ›οΈβŒ›οΈπŸ‘³πŸ™πŸ’₯πŸ˜΄πŸ›ŒπŸ˜³πŸ’₯πŸ›πŸ’₯πŸ‘Šβš”πŸ‘‘ The line in emoji-test contains two [πŸ› emojis](https://unicode-table.com/en/1F41B/). However, the first bug is followed by an invisible ["Variation Selector"](https://unicode-table.com/en/FE0F/). Here are the two bugs with a \uFE0F in the middle: πŸ›οΈπŸ› It looks like Tig renders the first bug without \uFE0F, but the test expects it. The same goes for the next visible character after the first bug: βŒ› is also followed by \uFE0F which is not rendered. Fix the test failure by removing both invisible characters from the expected output. This approach will probably break the test on other systems. I don't know if the character should be rendered. I want to find out why it fails on my system - maybe ncurses 6.2.1 doesn't render those control characters anymore?
1 parent a24d48e commit d885d49

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

β€Žtest/main/emoji-test

+1-1
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ EOF
5757
test_case emoji-commit-titles-col-300 \
5858
--subshell='export COLUMNS=300' \
5959
<<EOF
60-
2009-04-06 01:44 +0000 Committer o [master] πŸŒπŸ’§βœ‹πŸ•‹πŸ—‘πŸš€πŸœβ˜€οΈπŸŒ‘πŸŒΆπŸ’―πŸš±β³πŸŒ…πŸŒ‘πŸ˜‘πŸ’‰πŸ˜±πŸ˜ˆπŸ’€πŸ’₯πŸŒ›πŸŒ™πŸ­πŸ’₯πŸšΆπŸ»γ€°πŸ›οΈβŒ›οΈπŸ‘³πŸ™πŸ’₯πŸ˜΄πŸ›ŒπŸ˜³πŸ’₯πŸ›πŸ’₯πŸ‘Šβš”πŸ‘‘
60+
2009-04-06 01:44 +0000 Committer o [master] πŸŒπŸ’§βœ‹πŸ•‹πŸ—‘πŸš€πŸœβ˜€οΈπŸŒ‘πŸŒΆπŸ’―πŸš±β³πŸŒ…πŸŒ‘πŸ˜‘πŸ’‰πŸ˜±πŸ˜ˆπŸ’€πŸ’₯πŸŒ›πŸŒ™πŸ­πŸ’₯πŸšΆπŸ»γ€°πŸ›βŒ›πŸ‘³πŸ™πŸ’₯πŸ˜΄πŸ›ŒπŸ˜³πŸ’₯πŸ›πŸ’₯πŸ‘Šβš”πŸ‘‘
6161
2009-03-28 13:22 +0000 Committer o πŸ’„ Polish the UI
6262
2009-03-20 01:00 +0000 Committer o πŸ“š Document new feature
6363
2009-03-11 12:38 +0000 Committer o 🎨 Reformat the code

0 commit comments

Comments
Β (0)