Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hackney version needs updated to fix HTTPS key retrieval #8

Closed
jonryser opened this issue Sep 25, 2019 · 3 comments
Closed

Hackney version needs updated to fix HTTPS key retrieval #8

jonryser opened this issue Sep 25, 2019 · 3 comments

Comments

@jonryser
Copy link

Related: benoitc/hackney#591

The fix has been in the Hackney code for a couple of days, but an actual release was just made. Proposing we update the version dependency in mix.exs to read {:hackney, "~> 1.15.2"}.

@ltj
Copy link
Contributor

ltj commented Sep 26, 2019

Created PR #9

@victorolinasc
Copy link
Collaborator

Thanks for your PR! I'll take a closer look at it in a moment.

Just to note that you can override the dep with {:hackney, "~> 1.15.2", override: true} in your mix.exs. That should work too without a new release.

I will, of course, bump the dep once I get the time to test it properly.

Thanks a lot for letting us know about the issue on hackney!

@victorolinasc
Copy link
Collaborator

There was not much to test :)

Thanks again for your PR @ltj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants