Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove advanced mode #441

Closed
ghost opened this issue Aug 2, 2022 · 3 comments · Fixed by #443
Closed

Remove advanced mode #441

ghost opened this issue Aug 2, 2022 · 3 comments · Fixed by #443
Labels
tech dept Removes some technical debt

Comments

@ghost
Copy link

ghost commented Aug 2, 2022

Once #430 is merged, we're feature complete in a way that we can remove the "Developer/Advanced" mode we had until now.

@ghost ghost added the tech dept Removes some technical debt label Aug 2, 2022
@ghost ghost added this to the v0.0.10 - Jam it in there! milestone Aug 2, 2022
@ghost ghost added this to JAM Aug 2, 2022
@ghost ghost mentioned this issue Aug 2, 2022
@dergigi
Copy link
Contributor

dergigi commented Aug 2, 2022

Wohoo! 🎉

@theborakompanioni
Copy link
Collaborator

theborakompanioni commented Aug 3, 2022

Is this targeting the whole "developer mode" flag, or just harmonizing the diverging views ("CurrentWalletMagic" and "CurrentWalletAdvanced")?

There is an upcoming feature regarding better user feedback by adding the ability to view the raw jmwalletd log.. would it make sense to keep the toggle and show this new functionality only for users activating the "developer mode"? Will open a ticket for that one as I am not quite sure where to put it and your opinion would be very valuable.

@ghost
Copy link
Author

ghost commented Aug 3, 2022

No I don't think we need a dedicated developer mode. If someone wants to view the logs, they should be able to access the logs. There's no benefit to hide them in a developer mode that first needs to be toggled imo. This is similar to how we now also show "advanced" settings e.g. on the Earn screen without first needing to toggle some global advanced mode.

@ghost ghost closed this as completed in #443 Aug 3, 2022
@ghost ghost moved this to Done ✅ in JAM Aug 3, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech dept Removes some technical debt
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants