Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Earn: show offer and fee settings when earn is active #399

Closed
dergigi opened this issue Jul 14, 2022 · 5 comments · Fixed by #461
Closed

Earn: show offer and fee settings when earn is active #399

dergigi opened this issue Jul 14, 2022 · 5 comments · Fixed by #461
Assignees
Labels
UI/UX Issue related to cosmetics, design, or user experience

Comments

@dergigi
Copy link
Contributor

dergigi commented Jul 14, 2022

There is no way to tell what fees you've set when earn is active. You would have to stop the maker service.

All we show currently is this:

Screenshot 2022-07-14 at 08 36 55

I imagine something like the following would be useful:

Offering a minimum amount of 100,000 sats at a 0.03% fee.

or, when the offer is absolute

Offering a minimum amount of 100,000 sats at a 250 sat fee.


Basically show whatever was set here:

Screenshot 2022-07-14 at 08 34 11

@dergigi dergigi added good first issue Good for newcomers UI/UX Issue related to cosmetics, design, or user experience labels Jul 14, 2022
@dergigi dergigi added this to the v0.0.10 - Jam it in there! milestone Jul 14, 2022
@dergigi dergigi added this to JAM Jul 14, 2022
@theborakompanioni
Copy link
Collaborator

This is currently not possible within the current api functionality.
A workaround like saving it to local storage, won't give reliable results if users change browsers.
Will open a ticket in the backend repo shortly.

@ghost ghost added the blocked Merging this pull request is blocked until another issue is resolved label Jul 28, 2022
@ghost
Copy link

ghost commented Jul 28, 2022

Blocking this issue. If possible, please link the backend issue @theborakompanioni, I couldn't find it myself. 🤔

@theborakompanioni
Copy link
Collaborator

Blocking this issue. If possible, please link the backend issue @theborakompanioni, I couldn't find it myself. thinking

Thanks for reminding me.. here it is: "Current maker offer/counterparty via RPC API #1326"

@ghost
Copy link

ghost commented Aug 2, 2022

Removing this from v0.0.10 and moving to v0.1.0 as I don't think we'll get a working solution in the next couple of days.

@theborakompanioni
Copy link
Collaborator

This is unblocked when JoinMarket-Org/joinmarket-clientserver#1328 is merged.

@theborakompanioni theborakompanioni self-assigned this Aug 9, 2022
@theborakompanioni theborakompanioni removed the blocked Merging this pull request is blocked until another issue is resolved label Aug 10, 2022
@dergigi dergigi moved this to Done ✅ in JAM Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI/UX Issue related to cosmetics, design, or user experience
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants