From 00bb122e0f086515473a0ef562b02e77cf553409 Mon Sep 17 00:00:00 2001
From: JohnnyChen <johnnychen94@hotmail.com>
Date: Wed, 15 May 2019 15:12:23 +0800
Subject: [PATCH] fix isinteger

fixes #120 : `isinteger(1N0f8)` should be true
---
 src/FixedPointNumbers.jl | 4 ++--
 src/normed.jl            | 3 +++
 test/fixed.jl            | 8 ++++++++
 test/normed.jl           | 8 ++++++++
 4 files changed, 21 insertions(+), 2 deletions(-)

diff --git a/src/FixedPointNumbers.jl b/src/FixedPointNumbers.jl
index 9e77efa2..308628de 100644
--- a/src/FixedPointNumbers.jl
+++ b/src/FixedPointNumbers.jl
@@ -5,8 +5,8 @@ module FixedPointNumbers
 using Base: reducedim_initarray
 
 import Base: ==, <, <=, -, +, *, /, ~, isapprox,
-             convert, promote_rule, show, isinteger, abs, decompose,
-             isnan, isinf, isfinite,
+             convert, promote_rule, show, eger, abs, decompose,
+             isnan, isinf, isfinite, isinteger,
              zero, oneunit, one, typemin, typemax, floatmin, floatmax, eps, sizeof, reinterpret,
              float, trunc, round, floor, ceil, bswap,
              div, fld, rem, mod, mod1, fld1, min, max, minmax,
diff --git a/src/normed.jl b/src/normed.jl
index 6a4faed2..67b87e3a 100644
--- a/src/normed.jl
+++ b/src/normed.jl
@@ -169,3 +169,6 @@ end
 
 _unsafe_trunc(::Type{T}, x::Integer) where {T} = x % T
 _unsafe_trunc(::Type{T}, x) where {T}          = unsafe_trunc(T, x)
+
+# predicates
+isinteger(x::Normed{T,f}) where {T,f} = (x.i%(1<<f-1)) == 0
diff --git a/test/fixed.jl b/test/fixed.jl
index 3ffab5ff..8d2e63ac 100644
--- a/test/fixed.jl
+++ b/test/fixed.jl
@@ -146,6 +146,14 @@ end
     @test floatmin(Q11f4) == Q11f4(0.06)
 end
 
+@testset "isinteger" begin
+    # issue #120
+    for T in (Fixed{Int8,6}, Fixed{Int16,8}, Fixed{Int16,10}, Fixed{Int32,16})
+        a = 1
+        @test all(isinteger.(T.(a)))
+    end
+end
+
 @testset "Disambiguation constructors" begin
     @test_throws ArgumentError Fixed{Int32,16}('a')
     @test_throws InexactError  Fixed{Int32,16}(complex(1.0, 1.0))
diff --git a/test/normed.jl b/test/normed.jl
index 185fde44..6721bb89 100644
--- a/test/normed.jl
+++ b/test/normed.jl
@@ -345,6 +345,14 @@ end
     @test summary(view(a, 1:2)) == "2-element view(::Array{N0f8,1}, 1:2) with eltype Normed{UInt8,8}"
 end
 
+@testset "isinteger" begin
+    # issue #120
+    for T in (Normed{UInt8,6}, Normed{UInt16,8}, Normed{UInt16,10}, Normed{UInt32,16})
+        a = 1
+        @test all(isinteger.(T.(a)))
+    end
+end
+
 @testset "disambiguation constructors" begin
     @test_throws ArgumentError Normed{UInt32,16}('a')
     @test_throws InexactError  Normed{UInt32,16}(complex(1.0, 1.0))