Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maven-plugin broken due to typo in Jsonschema2PojoMojo Line 728: @parameter property contains dangling '}' #880

Closed
SKuettner opened this issue Jun 13, 2018 · 4 comments
Milestone

Comments

@SKuettner
Copy link

Maven Plugin in 1.0.0-alpha3 is broken and unusable. Remove the '}' to fix this.

/**
     * The type of code that will be generated.
     * <p>
     * Supported values:
     * <ul>
     * <li><code>java</code> (Generate .java source files)</li>
     * <li><code>scala</code> (Generate .scala source files, using scalagen)</li>
     * </ul>
     *
     * @parameter property="jsonschema2pojo.targetLanguage"
     *            default-value="java"
     * @since 0.5.0
     */
    private String targetLanguage = "java";

@SKuettner SKuettner changed the title maven-plugin broken due due typo in Jsonschema2PojoMojo Line 728: @parameter property contains dangling '}' maven-plugin broken due to typo in Jsonschema2PojoMojo Line 728: @parameter property contains dangling '}' Jun 13, 2018
@joelittlejohn
Copy link
Owner

Hi Stefan. Thanks for reporting this. I've pushed a commit that fixes a few of these errors. I don't have time to build and verify this right now, would you be able to mvn install a snapshot version from the current HEAD and try that version?

@SKuettner
Copy link
Author

Seems to work now. Closed.

@joelittlejohn
Copy link
Owner

@SKuettner Did you build the latest snapshot to verify this?

@joelittlejohn joelittlejohn reopened this Jun 13, 2018
@joelittlejohn joelittlejohn added this to the 1.0.0-alpha4 milestone Jun 13, 2018
@SKuettner
Copy link
Author

@joelittlejohn: Yes, I did. Can't build the whole multimodule because I don't get the gradle plugin module test accessing the internet to run behind our Firewall but I excluded it and was able to build the latest SNAPSHOT from master. I've tested the maven-plugin with our modules and it did the job as well as the stable version (0.5.1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants