Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always pass enclosing class or enum to annotator methods (changes method signatures) #876

Closed
joelittlejohn opened this issue Jun 8, 2018 · 0 comments
Labels
Milestone

Comments

@joelittlejohn
Copy link
Owner

This allows annotators to refer to classes that aren't on the classpath, which in turn allows jsonschema2pojo to support integration with new libraries without introducing a runtime dependency on those libraries.

To do this, every method on the annotator needs to be given a way to grab the current package, or some other construct that can refer to classes directly using a fully qualified name.

This is a breaking change since many of the annotator method signatures need to change to include the class or enum currently being worked on.

@joelittlejohn joelittlejohn added this to the 1.0.0-alpha3 milestone Jun 8, 2018
@joelittlejohn joelittlejohn changed the title Ensure annotators can always create direct class references Always pass enclosing class or enum to annotator methods (changes method signatures) Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant