asdf #2
Merged
asdf #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix log diagnostics tests and remove unused notification * Replace deprecated OCMock methods with notification expectations * Bump Core and CoreDiagnostics versions * Defer Core version update until release Co-authored-by: Paul Beusterien <[email protected]>
* Migrate libFuzzer from svn to git Now that the llvm project has completed its migration to git, the svn checkouts are now failing. * Find protoc even if homebrew isn't in /usr/local
…log filters anymore (#7230)
…callback scheme (#7211) * Check if reverse client ID is registered as a custom URL scheme before setting it as the callback scheme. * Fix existing tests. * Add tests. * Update changelog.
* Implement RTDB Query get * changelog * Mark query inactive after callback * Add tests, fix some issues * some small fixes * Fix tests * Review feedback * Address review feedback + fixup tests * Remove extra logs * Update FirebaseDatabase/Sources/Core/FPersistentConnection.m Co-authored-by: Sebastian Schmidt <[email protected]> * Review feedback * Write to unique paths * Removed FIR prefix * Add _Nullable specifiers in FRepo.h * format nullability stuff * fix get cache test Co-authored-by: Sebastian Schmidt <[email protected]>
* shareLoginAcrossDevices * shareLoginAcrossDevices * shareLoginAcrossDevices * shareLoginAcrossDevices * formatting * feedback changes * linted
* Restores ML Pods after M77. * Fix Package.swift * Refactor model info to be in-memory. * Add improved model download functionality w/ single set of download handlers per task. * Rename model download to better match URLSessionTask. * Rename model download to better match URLSessionTask. * Update unit test to read/write to user defaults. * Configure downloader with Firebase app. * Minor updates to model downloader and tests. * Singleton for model downloader instance, for default and custom app. * Download types WIP - local model. * Download types WIP. * Manually add app lifecycle handling + TODOs for Firebase Components. * Replace options with app name as a property in ModelDownloader. * Download types WIP. * Refactor model info. * Add convenience inits + other minor fixes. * Explicit enum for model info result.
* Update CHANGELOG. * Update version number.
Create coverage reports for PRs when PRs are updated.
* Restores ML Pods after M77. * Fix Package.swift * Re-add catalyst to GHA workflow. * Replace picker with text field for model name in test app.
* Trigger a workflow when a pr is created. * Remove redundant comments and update variables.
…last shared pointer to it is in a listener (#7421) If a user calls terminate and immediately disposes their reference to Firestore, it's possible that while termination is in process, the last remaining reference (more precisely, shared pointer) to Firestore is in a listener. When that listener is destroyed as part of the termination, it leads to `api::Firestore` being destroyed. Importantly, termination happens on the worker queue. The destructor of `api::Firestore` calls `Dispose` which presumes it's not called from the worker queue and tries to enqueue work, leading to a failing assertion and a crash. The solution is simply to remove the sequential order checks when the queue enters/is in restricted mode. There is a legitimate case where the Firestore destructor can run on the worker queue, as the original issue shows. The complexity of #7412 also indicates that a simpler solution is preferable. Fixes #6909.
* Restores ML Pods after M77. * Fix Package.swift * Re-add catalyst to GHA workflow. * Merge duplicate model download requests. * Remove print statement. * WORK IN PROGRESS - Test for merging requests * Unit tests for merging requests. * Fix unit test description. * Uncomment debug logging
Addressing feedback from #7421.
* GHA zip workflow: add manual trigger * avoid env * Wrap URL * temp enable for pull requests * Revert package on pull request * allow conditional steps for manual trigger
…URL (#7306) * Start tracking conversions on in-app message campaigns that don't have an action URL. Do this at impression time. (Initial implementation commit) * Add test coverage, use FIRIAMMessageDefinition in implementation for cleaner code all-around * Add CHANGELOG * Update CHANGELOG
* Better accessibility labels for FIAM images and close buttons * At FIAM display time, announce that the message has appeared in VoiceOver mode * In VoiceOver mode, announce the close button last. This is a better accessibility experience for finding the close button. * For modal messages, include the action button in accessibility elements. Exclude the image view if there's no image. * Update CHANGELOG * Include campaign name in accessibility label for images * Fix failing modal message UI tests
* RTDB FSRWebSocket: suppress diagnostic error * Use macro instead of a constant * Changelog * typo
This adds support for specifying alternative server timestamp behaviors when decoding snapshots. Fixes #6328.
* Add debug logging around token expiration. * Use FIRLogger instead of NSLog. * Move log statement. * Add another log statement when access token is updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asdf