Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change public method register_entity name #113

Closed
joegasewicz opened this issue Dec 6, 2019 · 2 comments · Fixed by #118
Closed

Change public method register_entity name #113

joegasewicz opened this issue Dec 6, 2019 · 2 comments · Fixed by #118
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@joegasewicz
Copy link
Owner

Change public method register_entity name to create_token
@joegasewicz joegasewicz added help wanted Extra attention is needed good first issue Good for newcomers labels Dec 6, 2019
@neilong31
Copy link
Contributor

Hey @joegasewicz ! I can do this!

@neilong31 neilong31 mentioned this issue Dec 6, 2019
Merged
@joegasewicz
Copy link
Owner Author

Thank you @neilong31

joegasewicz added a commit that referenced this issue Dec 10, 2019
@joegasewicz
Pre-flight OPTIONS only set on POST #63
ff63e18 
**Release 0.0.25** - 2019-12-10

- Replaced the the `entity_type` kwarg to `table_name` in the public method `register_entity` [Issue #111](#111)
- Renamed the `update_entity` public method to be called `update_token` [Issue #114](#114)
- Renamed the `register_entity` public method to be called `create_token` [Issue #113](#113)
- Add Models to JWTRoutes class & init_app method [Issue #119](#119)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changed register_entity to create_token neilong31/Flask-JWT-Router
2 participants
@joegasewicz @neilong31