Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addLabels for auditing #120

Open
tehlers320 opened this issue Oct 19, 2022 · 2 comments
Open

addLabels for auditing #120

tehlers320 opened this issue Oct 19, 2022 · 2 comments

Comments

@tehlers320
Copy link
Contributor

is there any objection to adding this feature back?

values.yaml used to have

  deployment:
    replicaCount: 1
    additionalLabels: {}
@joe-elliott
Copy link
Owner

No objections. Feel free to add it back. It was probably accidentally removed. If you can submit a PR Ill do a build.

❤️ tf2 engie

@tehlers320
Copy link
Contributor Author

tehlers320 commented Oct 19, 2022 •
edited
Loading

Im actually confused im on chart 2.5.2 .... which i cant find anywhere. Was i using a beta branch?

edit: DOH, its my own forked helm of your chart.... Ill work on backporting it.

@tehlers320 tehlers320 changed the title addLabels was removed from 3.x helm chart addLabels for auditing Oct 19, 2022
@tehlers320 tehlers320 mentioned this issue Oct 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joe-elliott @tehlers320