Makefile: highlighting error for include and functions

[gcapes]

I maintain the Software Carpentry lesson on Make, and I have noticed that the syntax highlighting doesn't work correctly for include and when using functions e.g. wildcard and patsubst.

See swcarpentry/make-novice#134 (comment) and screenshot below:

[stale]

This contribution has been automatically marked as stale because it has not had any activity for more than a year. It will be closed if no additional activity occurs within the next 14 days.

[gcapes]

@rouge-ruby
Any thoughts on this?

[pyrmont]

@gcapes Hmmm... seems that although the keywords are defined (see below) they're never used in any of the rules:

rouge/lib/rouge/lexers/make.rb

Lines 14 to 16 in a03a3b3

	bsd_special = %w(
	include undef error warning if else elif endif for endfor
	)

This is clearly a bug in the Make lexer. I don't mean to be the bearer of bad news but I'm afraid that it's unlikely this will get fixed soon without someone submitting a PR. We're doing our best to clear up the backlog after Rouge's hiatus but there's quite a lot to get through before we start looking at addressing individual issues :(

I will say that we are reviewing the newest PRs first, so if you wanted to take a stab at this yourself, your PR would be go to the top of the pile (or stack, as it were)! I became a maintainer recently and wrote a guide to lexer development that might be of some assistance.

[pyrmont]

Oh, and for future testing, here's the code I used to test:

include config.mk

TXT_FILES=$(wildcard books/*.txt)

[gcapes]

Looks like this issue is now fixed. Thanks!