Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thanks for this library! #1

Open
anfleene opened this issue Mar 8, 2016 · 4 comments
Open

Thanks for this library! #1

anfleene opened this issue Mar 8, 2016 · 4 comments

Comments

@anfleene
Copy link

anfleene commented Mar 8, 2016

Thanks for this. It's one of the only implementations of a timeout in ruby that will actually timeout when it is supposed to. One problem we had with it is that we don't want to use it for everything just specific http requests. Would you be open to accepting a PR that wraps the entire library in a SaneTimeout module? Namespacing it and allow it to be used at will vs requiring it to be used on every timeout has worked very well for us. Here are the changes we've made so far master...sportngin:master

@jjb
Copy link
Owner

jjb commented Mar 8, 2016

good to hear someone is finding it useful!

i'm definitely open to that. i might not get around to reviewing and
merging for a while though.

@jjb
Copy link
Owner

jjb commented Sep 18, 2021

Hi @anfleene - i'm thinking of sprucing this up - do you still use it anywhere in prod?

@anfleene
Copy link
Author

AFIK SportsEngine still uses those changes in production. I left 3 months ago so I can't really speak for them. And I'm no longer in ruby land in my new gig.

@jjb
Copy link
Owner

jjb commented Sep 20, 2021

Great, thanks for the info, and have fun at your new gig!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants