-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thanks for this library! #1
Comments
good to hear someone is finding it useful! i'm definitely open to that. i might not get around to reviewing and |
Hi @anfleene - i'm thinking of sprucing this up - do you still use it anywhere in prod? |
AFIK SportsEngine still uses those changes in production. I left 3 months ago so I can't really speak for them. And I'm no longer in ruby land in my new gig. |
Great, thanks for the info, and have fun at your new gig! |
Thanks for this. It's one of the only implementations of a timeout in ruby that will actually timeout when it is supposed to. One problem we had with it is that we don't want to use it for everything just specific http requests. Would you be open to accepting a PR that wraps the entire library in a SaneTimeout module? Namespacing it and allow it to be used at will vs requiring it to be used on every timeout has worked very well for us. Here are the changes we've made so far master...sportngin:master
The text was updated successfully, but these errors were encountered: