Having issue when using URI components to escape URLs in 1.15.4

[linweiyuan]

I have an auth api using jsoup to call, when I use 1.15.3, works fine, but yesterday I upgraded it to 1.15.4, a 400 bad request was returned. The url has an encoded space (%20) like https://auth0.xxx.com/authorize?client_id=xxx&scope=openid%20email%20profile, in 1.15.4 will be encoded to https://auth0.xxx.com/authorize?client_id=xxx&scope=openid%2520email%2520profile, the '%' is also encoded.

I debug and found this commit: 45ed002#diff-50cf357d24b529d8ec8ffd200e666d29cb8286c71733da1a27c9b32d1204d676

It is easy to reproduce:

Connection connect = Jsoup.connect("https://the-site/a%20b%20c");
System.out.println(connect.request().url());

Can help to have a look? Thanks in advance.

[jhy]

Ah, nuts!

I thought we had tests for this, but there's only the single direction:

jsoup/src/test/java/org/jsoup/helper/HttpConnectionTest.java

Lines 257 to 261 in da5e977

	@Test public void encodeUrl() throws MalformedURLException {
	URL url1 = new URL("https://test.com/foo bar/[One]?q=white space#frag");
	URL url2 = HttpConnection.encodeUrl(url1);
	assertEquals("https://test.com/foo%20bar/%5BOne%5D?q=white%20space#frag", url2.toExternalForm());
	}

[jhy]

Fixed -- thanks for the report! And apologies for the regression.