protoparse: fix extension resolution in custom options #484
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way protoparse resolved references to extension names in custom options (both in option names and also in field names inside message literal values) did not work exactly like protoc.
Example file:
As seen in comments above, there were some names that protoc resolves that cause errors in protoparse. And vice versa: there is one extension that protoparse was able to resolve, but should not have been if adhering to the same scoping rules that protoc implements.
Also visible above: protoc is consistent with how names are resolved, whether they are field names in message literals vs. in option names. But protoparse was quite inconsistent.
This PR fixes this and includes lots of fun tests to verify that all forms accepted by protoc are accepted by protoparse and also that forms rejected by protoc are also rejected by protoparse.