Skip to content

Commit 3eb0327

Browse files
committed
Ensure Firefox frame table subcategory fields are always included
1 parent c4e1980 commit 3eb0327

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

lib/vernier/output/firefox.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -497,7 +497,7 @@ def frame_table
497497
address: [-1] * size,
498498
inlineDepth: [0] * size,
499499
category: categories,
500-
subcategory: nil,
500+
subcategory: none,
501501
func: funcs,
502502
nativeSymbol: none,
503503
innerWindowID: none,

test/firefox_test_helpers.rb

+2
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,8 @@ def assert_valid_firefox_profile(profile)
6262
assert_equal frame_length, thread["frameTable"]["innerWindowID"].length
6363
assert_equal frame_length, thread["frameTable"]["func"].length
6464
assert_equal frame_length, thread["frameTable"]["category"].length
65+
assert_equal frame_length, thread["frameTable"]["subcategory"].length
66+
assert_equal [], thread["frameTable"]["subcategory"].compact
6567
assert_equal frame_length, thread["frameTable"]["inlineDepth"].length
6668
assert_equal frame_length, thread["frameTable"]["address"].length
6769

0 commit comments

Comments
 (0)