-
-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for standalone components #484
Conversation
this will make it possible to completely remove NgModule
with the first option - Convert all components, directives and pipes to standalone add option ``"newlines-between": "never"` to eslint rule import/order because the angular script that removed the imports left empty lines reformatted some files as the angular script has changed some files styles tried to minimize the changes
with the first option - Remove unnecessary NgModule classes reformatted some files as the angular script has changed some files styles tried to minimize the changes
with Bootstrap the application using standalone APIs - clean the generated content - refactor the code into `app.config.ts` to match new angular projects
mark MarkdownModule as deprecated and warn in the console if in dev mode to use the new provideMarkdown
@jfcere @michaelfaith this is the new PR |
demo/src/app/shared/scrollspy-nav-layout/scrollspy-nav-layout.component.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this change! Thanks again for taking it on. @jfcere Do you think there should be an adjustment to the usage info on the README with this change?
oh yeah I forget the README file |
I'm also okay with you adding commits to this PR |
@robertIsaac, @michaelfaith I've updated the |
hi @jfcere I can't approve since I'm the author, but LGTM |
New features and enhancements
Fix #458, #483
add
provideMarkdown
as a new way to configure ngx-markdownrun
ng generate @angular/core:standalone
with the three optionsclean the generated content
add option
"newlines-between": "never"
to eslint rule import/orderbecause the angular script that removed the imports left empty lines
reformatted some files as the angular script has changed some files styles
tried to minimize the changes
refactor the code into
app.config.ts
to match new angular projectsmove routing to the new standalone