Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for standalone components #484

Merged
merged 13 commits into from
Nov 13, 2023
Merged

Conversation

robertIsaac
Copy link
Contributor

@robertIsaac robertIsaac commented Nov 11, 2023

New features and enhancements

  • Add support for standalone component

Fix #458, #483


  • add provideMarkdown as a new way to configure ngx-markdown

  • run ng generate @angular/core:standalone with the three options

    • Convert all components, directives and pipes to standalone
    • Remove unnecessary NgModule classes
    • Bootstrap the application using standalone APIs
  • clean the generated content

    • add option "newlines-between": "never" to eslint rule import/order
      because the angular script that removed the imports left empty lines

    • reformatted some files as the angular script has changed some files styles
      tried to minimize the changes

    • refactor the code into app.config.ts to match new angular projects

  • move routing to the new standalone

this will make it possible to completely remove NgModule
with the first option
- Convert all components, directives and pipes to standalone

add option ``"newlines-between": "never"` to eslint rule import/order
  because the angular script that removed the imports left empty lines

reformatted some files as the angular script has changed some files styles
  tried to minimize the changes
with the first option
- Remove unnecessary NgModule classes

reformatted some files as the angular script has changed some files styles
  tried to minimize the changes
with Bootstrap the application using standalone APIs
- clean the generated content
- refactor the code into `app.config.ts` to match new angular projects
mark MarkdownModule as deprecated and warn in the console if in dev mode to use the new provideMarkdown
@robertIsaac
Copy link
Contributor Author

@jfcere @michaelfaith this is the new PR
I hope I didn't forget any points from the other one

@jfcere jfcere changed the title Standalone Add support for standalone components Nov 11, 2023
Copy link

@michaelfaith michaelfaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this change! Thanks again for taking it on. @jfcere Do you think there should be an adjustment to the usage info on the README with this change?

@robertIsaac
Copy link
Contributor Author

Great work on this change! Thanks again for taking it on. @jfcere Do you think there should be an adjustment to the usage info on the README with this change?

oh yeah I forget the README file
I will wait for @jfcere reply if he wish to update it or not, and if he is fine with it I will go and update it

@robertIsaac
Copy link
Contributor Author

I'm also okay with you adding commits to this PR

@jfcere
Copy link
Owner

jfcere commented Nov 12, 2023

Great work on this change! Thanks again for taking it on. @jfcere Do you think there should be an adjustment to the usage info on the README with this change?

oh yeah I forget the README file I will wait for @jfcere reply if he wish to update it or not, and if he is fine with it I will go and update it

@robertIsaac, @michaelfaith I've updated the README.md to reflect the standalone changes, feel free to revise the changes and comment.

@robertIsaac
Copy link
Contributor Author

hi @jfcere I can't approve since I'm the author, but LGTM
I see I forget to add the withInMemoryScrolling from the last PR, thanks for taking care of that

@jfcere jfcere merged commit e1245d4 into jfcere:master Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Enable Standalone API
3 participants