Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngx-markdown.js depends on 'marked' #266

Closed
gonzalo-roberto-diaz opened this issue Oct 28, 2020 · 3 comments
Closed

ngx-markdown.js depends on 'marked' #266

gonzalo-roberto-diaz opened this issue Oct 28, 2020 · 3 comments
Labels
enhancement Improvement request

Comments

@gonzalo-roberto-diaz
Copy link

Hello.

When building my project, which uses ngx-markdown issuin the command

ng build --prod

I get the following warning:

WARNING in /Volumes/LaCie/dev/prekspanish-a9/node_modules/ngx-markdown/__ivy_ngcc__/fesm2015/ngx-markdown.js depends on 'marked'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Angular CLI: 10.2.0
Node: 12.18.3
OS: darwin x64

Angular: 10.2.0

@jfcere
Copy link
Owner

jfcere commented Nov 9, 2020

Hi @gonzalo-roberto-diaz

This is not such a big deal as the size of marked with gzip is ~11kB which is quite small.

image

@jfcere jfcere added the enhancement Improvement request label Nov 9, 2020
@Rambou
Copy link

Rambou commented Jul 13, 2022

Up for this request too!

@jfcere
Copy link
Owner

jfcere commented Nov 17, 2023

As per ngx-markdown v17.0.0 the marked dependency is imported using ECMAScript Modules and won't trigger this warning anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement request
Projects
None yet
Development

No branches or pull requests

3 participants