Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace non-inclusive terms used in configuration of jest-validate #10235

Closed
wojtekmaj opened this issue Jul 3, 2020 · 2 comments · Fixed by #10650
Closed

Replace non-inclusive terms used in configuration of jest-validate #10235

wojtekmaj opened this issue Jul 3, 2020 · 2 comments · Fixed by #10650

Comments

@wojtekmaj
Copy link
Contributor

🚀 Proposal

  • Introduce recursiveDenylist option in jest-validate's ValidationOptions as a racially neutral alternative to recursiveBlacklist. Do not remove recursiveBlacklist just yet in order not to introduce a breaking change.

  • Warn against using recursiveBlacklist.

  • Remove recursiveBlacklist in the next major version after warning has been set up.

Motivation

Part of continuous effort to get rid of non-inclusive terms like "whitelist" and "blacklist" implying that white = good and black = bad.

I'd be more than happy to contribute the first bullet point by adding something along the lines of recursiveDenylist || recursiveBlacklist where applicable, if you think this is a good idea.

@thymikee
Copy link
Collaborator

thymikee commented Jul 3, 2020

Let's do this

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants