From c9504b9887ece617395e9f4f7e28b7e005f1eec9 Mon Sep 17 00:00:00 2001 From: Simen Bekkhus Date: Wed, 22 Jan 2020 11:59:35 +0100 Subject: [PATCH] chore(docs): link to jsdom@16 env for v8 code coverage support Closes #9315 --- docs/CLI.md | 2 +- docs/Configuration.md | 2 +- website/versioned_docs/version-25.1/CLI.md | 2 +- website/versioned_docs/version-25.1/Configuration.md | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/CLI.md b/docs/CLI.md index eab4a69e7025..8a6d09579b23 100644 --- a/docs/CLI.md +++ b/docs/CLI.md @@ -159,7 +159,7 @@ Indicates which provider should be used to instrument code for coverage. Allowed Note that using `v8` is considered experimental. This uses V8's builtin code coverage rather than one based on Babel and comes with a few caveats 1. Your node version must include `vm.compileFunction`, which was introduced in [node 10.10](https://nodejs.org/dist/latest-v12.x/docs/api/vm.html#vm_vm_compilefunction_code_params_options) -1. Tests needs to run in Node test environment (support for `jsdom` is in the works, see [#9315](https://github.com/facebook/jest/issues/9315)) +1. Tests needs to run in Node test environment (support for `jsdom` requires [`jest-environment-jsdom-sixteen`](https://www.npmjs.com/package/jest-environment-jsdom-sixteen)) 1. V8 has way better data in the later versions, so using the latest versions of node (v13 at the time of this writing) will yield better results ### `--debug` diff --git a/docs/Configuration.md b/docs/Configuration.md index 9f0d18868b53..75791757fc6c 100644 --- a/docs/Configuration.md +++ b/docs/Configuration.md @@ -192,7 +192,7 @@ Indicates which provider should be used to instrument code for coverage. Allowed Note that using `v8` is considered experimental. This uses V8's builtin code coverage rather than one based on Babel and comes with a few caveats 1. Your node version must include `vm.compileFunction`, which was introduced in [node 10.10](https://nodejs.org/dist/latest-v12.x/docs/api/vm.html#vm_vm_compilefunction_code_params_options) -1. Tests needs to run in Node test environment (support for `jsdom` is in the works, see [#9315](https://github.com/facebook/jest/issues/9315)) +1. Tests needs to run in Node test environment (support for `jsdom` requires [`jest-environment-jsdom-sixteen`](https://www.npmjs.com/package/jest-environment-jsdom-sixteen)) 1. V8 has way better data in the later versions, so using the latest versions of node (v13 at the time of this writing) will yield better results ### `coverageReporters` [array\] diff --git a/website/versioned_docs/version-25.1/CLI.md b/website/versioned_docs/version-25.1/CLI.md index 7d141a13fe16..4e2d93ef826a 100644 --- a/website/versioned_docs/version-25.1/CLI.md +++ b/website/versioned_docs/version-25.1/CLI.md @@ -160,7 +160,7 @@ Indicates which provider should be used to instrument code for coverage. Allowed Note that using `v8` is considered experimental. This uses V8's builtin code coverage rather than one based on Babel and comes with a few caveats 1. Your node version must include `vm.compileFunction`, which was introduced in [node 10.10](https://nodejs.org/dist/latest-v12.x/docs/api/vm.html#vm_vm_compilefunction_code_params_options) -1. Tests needs to run in Node test environment (support for `jsdom` is in the works, see [#9315](https://github.com/facebook/jest/issues/9315)) +1. Tests needs to run in Node test environment (support for `jsdom` requires [`jest-environment-jsdom-sixteen`](https://www.npmjs.com/package/jest-environment-jsdom-sixteen)) 1. V8 has way better data in the later versions, so using the latest versions of node (v13 at the time of this writing) will yield better results ### `--debug` diff --git a/website/versioned_docs/version-25.1/Configuration.md b/website/versioned_docs/version-25.1/Configuration.md index b47b69a90cd0..b153415aa060 100644 --- a/website/versioned_docs/version-25.1/Configuration.md +++ b/website/versioned_docs/version-25.1/Configuration.md @@ -193,7 +193,7 @@ Indicates which provider should be used to instrument code for coverage. Allowed Note that using `v8` is considered experimental. This uses V8's builtin code coverage rather than one based on Babel and comes with a few caveats 1. Your node version must include `vm.compileFunction`, which was introduced in [node 10.10](https://nodejs.org/dist/latest-v12.x/docs/api/vm.html#vm_vm_compilefunction_code_params_options) -1. Tests needs to run in Node test environment (support for `jsdom` is in the works, see [#9315](https://github.com/facebook/jest/issues/9315)) +1. Tests needs to run in Node test environment (support for `jsdom` requires [`jest-environment-jsdom-sixteen`](https://www.npmjs.com/package/jest-environment-jsdom-sixteen)) 1. V8 has way better data in the later versions, so using the latest versions of node (v13 at the time of this writing) will yield better results ### `coverageReporters` [array\]