Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update README.md to mention complete list of paths #33

Merged
merged 2 commits into from
Nov 6, 2021

Conversation

jovans-getpassport
Copy link
Contributor

Added more detailed explanation for changing the /package folder name.

Copy link
Owner

@jenstroeger jenstroeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @jovanspassport!

@jenstroeger jenstroeger added the documentation Improvements or additions to documentation label Nov 2, 2021
@jenstroeger jenstroeger changed the base branch from master to staging November 2, 2021 20:25
@jenstroeger jenstroeger changed the title chore: Updated README.md chore: update README.md to mention complete list of paths Nov 2, 2021
@jenstroeger
Copy link
Owner

Sorry, @jovanspassport, I wanted to fix the commit lint by fixing the PR title and I didn’t remember that the actual commit message must match. Would you mind amending your commit 0f6e7af with the subject equal to this PR title? (Note: lower-case and present tense.)

@jenstroeger
Copy link
Owner

Also, on second thought I think docs: might suit better than chore: in this case 🤔

Added more detailed explanation for changing the /package folder name.
@jovans-getpassport
Copy link
Contributor Author

@jenstroeger I changed the commit message.

@jenstroeger jenstroeger changed the title chore: update README.md to mention complete list of paths docs: update README.md to mention complete list of paths Nov 3, 2021
@jenstroeger jenstroeger merged commit b4daa56 into jenstroeger:staging Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants