Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification to use full project name #60

Closed
dave-miles opened this issue Mar 5, 2015 · 7 comments
Closed

Notification to use full project name #60

dave-miles opened this issue Mar 5, 2015 · 7 comments

Comments

@dave-miles
Copy link
Contributor

We use the CloudBees Folders Plugin a lot. Folders typically contain a project named 'build'. At present notifications don't include the full project name so can be ambiguous.

@samrocketman
Copy link
Member

That definitely sounds useful. I don't currently develop this plugin. I only maintain pull requests and releases. You're welcome to contribute this feature!

@samrocketman
Copy link
Member

I just noticed pull request #61. I'll test it out and if it works properly then I'll merge your change. Thanks.

@peergum
Copy link
Contributor

peergum commented Mar 6, 2015

This relates to the customization of messages. Making the project name display in full might not be suitable for everyone. For better compatibility this should be an option.

@samrocketman
Copy link
Member

I put the tag in the wrong place :)

@samrocketman
Copy link
Member

@peergum what's the difference between the two? I assume one shows the full path and the other does not (pending my own testing). I would think that would make sense.

The way I imagine it is projects are organized by folders (like GitHub orgs or groups). So if the project with the same name is in two different folders then one would not be able to differentiate between the two.

I don't want to put in too many options. I'm starting to feel the plugin has a lot of options already and don't want to paralyze plugin users with feature creep. I'll test PR #61 and see how it compares with/without the folder plugin. Feel free to peer review PR #61.

@s0undt3ch
Copy link

+1

@timja
Copy link
Member

timja commented Nov 28, 2018

61 was merged and released

@timja timja closed this as completed Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants