Add defined check for plugin_parent_dir resource #155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The management of the basic dependencies of a Jenkins plugin should not be unnecessarily forced on the user. This change wraps the plugin_parent_dir resource creation in a `defined` function to allow the user to create the Jenkins home directory themselves if necessary. This fixes voxpupuli#148 in a more backwards compatible way than voxpupuli#149.
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The management of the basic dependencies of a Jenkins plugin should not
be unnecessarily forced on the user. This change wraps the plugin_parent_dir
resource creation in a
definedfunction to allow the user to create theJenkins home directory themselves if necessary.
The use case for this would be a simple symbolic link resource that would link
the default
/var/lib/jenkinsparent directory to another location for storagespace, or other system reasons.
This fixes #148 in a more backwards compatible way than #149.