Add feature to disable SSL verification on Swarm clients #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck its value and set the disable_ssl_verification_flag variable accordingly. If the parameter is set to 'true', the -disableSslVerification is added to the init script template's start command.
…mand in the Swarm client init script.
…mand in the Swarm client init script.
…x:/var/git/puppet/office_modules/jenkins into feature/disable-swarm-ssl-verification-flag
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
We have two steps forward for this pull requests, either you can add some rspec-puppet tests for it @nickchappell or you can wait for me to get around to it (probably a week or two, since I've already squandered my weekend :)) |
|
Unfortunately, your time frame is probably better than mine. I won't have any time in the foreseeable future to add rspec tests. :( |
|
I'll add this to the next release after "this one" to get done then, hold on tight :) |
|
Closing this, as #122 was merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature adds a parameter to the
jenkins::slaveclass to control whether Swarm clients will verify the SSL cert of a Jenkins master, if the Jenkins master URL the client is using is HTTPS. For safety's sake, the default value is set tofalse.