Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can "params" be defined as a java.util.Collections$UnmodifiableMap instead of a regular map? #528

Closed
red8888 opened this issue May 24, 2022 · 1 comment · Fixed by #542
Closed

Comments

@red8888
Copy link

red8888 commented May 24, 2022

What feature do you want to see added?

Maybe I'm using it wrong but in an actual pipeline run the "params" variable is an java.util.Collections$UnmodifiableMap. When running the unit test pipeline framework it appears to be a regular map.

Maybe what I'm asking for is impossible. Got an exception because I tried to treat params like a Map when it is not. Ran locally without errors, but failed on actual Jenkins.

Thanks!

Upstream changes

No response

@nre-ableton
Copy link
Contributor

nre-ableton commented Jul 7, 2022

This is a good idea, and your reasoning makes perfect sense -- this framework should strive to emulate a real Jenkins server as much as possible. Unfortunately, this isn't a trivial fix because internally, we do need to modify the map in order to add parameters to it from calls made to addParam. So we need to think about a better solution to the problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants