gitlab approval webhooks unknown

[slimm609]

the approval webhook event should be treated as /approve or /lgtm commands so that lgtm and approve can pick them up based on plugin settings review_acts_as_lgtm: true

{"level":"info","msg":"500 Internal Server Error: Failed to parse webhook: Unknown webhook event: approval.","response":"500 Internal Server Error: Failed to parse webhook: Unknown webhook event: approval.","status-code":500,"time":"2020-11-24T19:47:40Z"}

[jenkins-x-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://jenkins-x.io/community.
/lifecycle stale

[msvticket]

Support exists for github, gitea and bitbucket server. So adding support for gitlab should be fairly straight forward.

I think what is needed is:

Support for ReviewHook that should be done here:

https://github.com/jenkins-x/go-scm/blob/main/scm/driver/gitlab/webhook.go#L42

You would also need to implement listing of reviews here: https://github.com/jenkins-x/go-scm/blob/5c9f9b4a8fb7f5bab33a387dfc63e6d6b31bf00c/scm/driver/gitlab/review.go#L21