Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove satori uuid package #7454

Closed
ankitm123 opened this issue Jul 18, 2020 · 3 comments · Fixed by #7455
Closed

Remove satori uuid package #7454

ankitm123 opened this issue Jul 18, 2020 · 3 comments · Fixed by #7455

Comments

@ankitm123
Copy link
Member

ankitm123 commented Jul 18, 2020 •
edited
Loading

Summary

See: satori/go.uuid#84

Checking go.mod, looks like we use three packages for generating uuid.
github.com/pborman/uuid
github.com/satori/go.uuid
github.com/google/uuid v1.1.1

Seems like only the google package has been updated recently. We should remove the other two.
@garethjevans
Copy link
Member

It would be worth thinking about banning the others in the linter config

@ankitm123
Copy link
Member Author

Yes, that would be nice as it would prevent any accidental inclusion of those other packages. I should have a PR ready by the EOD for this issue.

@ankitm123
Copy link
Member Author

Seems like depguard is the package that can be used.

@ankitm123 ankitm123 mentioned this issue Jul 18, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: use google uuid package for generating uuids in the codebase ankitm123/jx
2 participants
@garethjevans @ankitm123