Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markewaite as a folder-properties plugin maintainer #4268

Conversation

MarkEWaite
Copy link
Contributor

Add markewaite as a folder-properties plugin maintainer

https://github.com/jenkinsci/folder-properties-plugin

Plugin has not had commits in 5 years. Last comment from @mig82 was in 2021 as part of:

@mig82 if you comment in this pull request with your approval, that will allow me to help with the plugin sooner. If an approval comment is not received, then the two week adoption period will need to complete before I can help with the plugin.

Pull requests that I plan to merge and release:

When modifying release permission

List the GitHub usernames of the users who should have commit permissions below:

  • @MarkEWaite

This is needed in order to cut releases of the plugin or component.

If you are modifying the release permission of your plugin or component, fill out the following checklist:

Release permission checklist (for submitters)

Preview Give feedback

Reviewer checklist

Preview Give feedback

There are IRC Bot commands for it.

@MarkEWaite MarkEWaite requested a review from a team as a code owner January 20, 2025 18:56
@mig82
Copy link
Contributor

mig82 commented Jan 30, 2025

@MarkEWaite I'd be happy to get a hand with this.
I've not done any work on this because I've not seen any real asks since the unit tests were introduced.
About this one in particular, at the time I reviewed it and mentioned I was not ok with removing any guidance and screenshots. If you're going to merge it, can you please make sure that's the case?

Copy link
Contributor

@mig82 mig82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to get a helping hand here.

@mawinter69 mawinter69 merged commit 0279239 into jenkins-infra:master Jan 30, 2025
3 checks passed
@MarkEWaite MarkEWaite deleted the add-markewaite-to-folder-properties branch January 30, 2025 12:58
@MarkEWaite
Copy link
Contributor Author

I'd be happy to get a hand with this.

That sounds great. I'll try to be helpful and not be a hindrance. Please let me know if I do something that is a distraction or a problem.

About this one in particular, at the time I reviewed it and mentioned I was not ok with removing any guidance and screenshots. If you're going to merge it, can you please make sure that's the case?

Yes, I'll make sure that the pull request comments are addressed. Thanks for providing the comments!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants