fix the channel report #1108
Merged
fix the channel report #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The channel name was not being displayed on the report as the channel name and the channel id were not being injected into the report template. The two properties are in a nested data object, and it seems the HandleBar module which does the compiling and injection was failing to retrieve the properties. Logic has been added to put the propertes on the first layer where they can be easily retrieved. Some minor refactor has also been done MOM-651
Codecov Report
@@ Coverage Diff @@
## master #1108 +/- ##
==========================================
- Coverage 86.61% 86.54% -0.08%
==========================================
Files 77 77
Lines 4984 4986 +2
==========================================
- Hits 4317 4315 -2
- Misses 667 671 +4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The channel name was not being displayed on the report as the channel name and the channel id were not being injected into the report template. The two properties are in a nested data object, and it seems the HandleBar module which does the compiling and injection was failing to retrieve the properties. Logic has been added to put the propertes on the first layer where they can be easily retrieved. Some minor refactor has also been done
MOM-651