Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Characters in lock screen media controls are URL encoded #731

Closed
3 tasks
colonelpopcorn opened this issue Jul 12, 2022 · 1 comment · Fixed by #775
Closed
3 tasks

Characters in lock screen media controls are URL encoded #731

colonelpopcorn opened this issue Jul 12, 2022 · 1 comment · Fixed by #775
Labels
bug Something isn't working

Comments

@colonelpopcorn
Copy link
Contributor

colonelpopcorn commented Jul 12, 2022 •
edited
Loading

Describe the bug

  1. Go to music
  2. Select a track that has a character that needs to be URL encoded (e.g. a track by Coheed & Cambria)
  3. Lock your device or pull down from the top to view Jellyfin's media controls

Expected Result:
Artist name should show up without any escaped characters.

Actual result:
Artist name shows up with URL encoded characters (e.g. Coheed & Cambria)

Logs

No response

Application version

2.4.4

Where did you install the app from?

Google Play

Device information

moto g(8) plus

Android version

Android 10

Jellyfin server version

10.8.1

Which video player implementations does this bug apply to?

  • Web player (default)
  • Integrated player (ExoPlayer)
  • External player (VLC, mpv, MX Player)
@colonelpopcorn colonelpopcorn added the bug Something isn't working label Jul 12, 2022
@colonelpopcorn
Copy link
Contributor Author

It looks like we just have to url decode the toString calls on lines 105 and 108.
https://github.com/jellyfin/jellyfin-android/blob/master/app/src/main/java/org/jellyfin/mobile/player/audio/AudioNotificationManager.kt

@colonelpopcorn colonelpopcorn mentioned this issue Aug 31, 2022
Merged
@Maxr1998 Maxr1998 linked a pull request Aug 31, 2022 that will close this issue
Update notify method to strip escaped HTML characters. #775
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update notify method to strip escaped HTML characters. colonelpopcorn/jellyfin-android
1 participant
@colonelpopcorn