Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Rubocop versions above 1.18.x? #23

Closed
emmahsax opened this issue Feb 10, 2023 · 5 comments
Closed

Allow Rubocop versions above 1.18.x? #23

emmahsax opened this issue Feb 10, 2023 · 5 comments

Comments

@emmahsax
Copy link

emmahsax commented Feb 10, 2023

The requirements of this gem require rubocop ~> 1.18.0, meaning that Rubocop versions above 1.19.0 aren't allowed.

However, Rubocop doesn't support Ruby 3.2 until Rubocop version 1.26.0 Is there any reason we can't allow Rubocop 1.26 or higher?

$ bundle exec rubocop
Error: RuboCop found unknown Ruby version 3.2 in `.ruby-version`.
Supported versions: 2.5, 2.6, 2.7, 3.0, 3.1
@ashmaroli
Copy link
Member

Hello @emmahsax,
The reason this gem locks to a certain RuboCop version is because RuboCop releases new cops every now and then, often failing CI on lines of code unrelated to tested commit / pull request.
That said, there is no reason blocking this plugin from getting itself updated to allow upto RuboCop 1.26.x, other than lack of need / motivation.

@parkr
Copy link
Member

parkr commented Feb 16, 2023

I think we should upgrade. There's a rubocop failure in jekyll/github-metadata#245 that is an internal error within Rubocop. Since this is locked to 1.18.x, I can't test if it's fixed in a later version.

@parkr
Copy link
Member

parkr commented Feb 16, 2023

The reason this gem locks to a certain RuboCop version is because RuboCop releases new cops every now and then, often failing CI on lines of code unrelated to tested commit / pull request.

Might be worthwhile changing our config to disable new cops if we're worried about this:

AllCops:
    NewCops: enable

Either way, we can stay more up-to-date if we release this more often. That's made easier now by the addition of the release workflow, so we could potentially bump our rubocop dependency, then release a new version of rubocop-jekyll and keep the dependency fixed on a single minor version. Then, dependabot-based upgrades (at least for the plugin repos) would be able to get the upgrades but handle them in a PR.

@parkr
Copy link
Member

parkr commented Feb 17, 2023

Fixed by #27.

@parkr
Copy link
Member

parkr commented Feb 17, 2023

Follow #30 for updates. Everything is ready to go, but I can't push the update. Hold tight!

@parkr parkr closed this as completed Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants