-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Rubocop versions above 1.18.x? #23
Comments
Hello @emmahsax, |
I think we should upgrade. There's a rubocop failure in jekyll/github-metadata#245 that is an internal error within Rubocop. Since this is locked to 1.18.x, I can't test if it's fixed in a later version. |
Might be worthwhile changing our config to disable new cops if we're worried about this: AllCops:
NewCops: enable Either way, we can stay more up-to-date if we release this more often. That's made easier now by the addition of the release workflow, so we could potentially bump our rubocop dependency, then release a new version of rubocop-jekyll and keep the dependency fixed on a single minor version. Then, dependabot-based upgrades (at least for the plugin repos) would be able to get the upgrades but handle them in a PR. |
Fixed by #27. |
Follow #30 for updates. Everything is ready to go, but I can't push the update. Hold tight! |
The requirements of this gem require rubocop
~> 1.18.0
, meaning that Rubocop versions above1.19.0
aren't allowed.However, Rubocop doesn't support Ruby 3.2 until Rubocop version
1.26.0
Is there any reason we can't allow Rubocop 1.26 or higher?The text was updated successfully, but these errors were encountered: