Invalid highlight html with rouge and linenos

[kostrse]

Invalid HTML generated when highlighter set to rouge and highlight has option linenos.

For kramdown and redcarpet html is slightly different, but in both cases invalid.

Original markdown:

before

{% highlight cs linenos %}
abc
def
{% endhighlight %}

after

Resulting html for redcarpet:

<p>before</p>
<div class="highlight">
    <pre>
        <code class="language-cs" data-lang="cs">
            <table style="border-spacing: 0">
                <tbody>
                    <tr>
                        <td class="gutter gl" style="text-align: right">
                            <pre class="lineno">
                                1
                                2
        </code>
                            </pre>
                        </td>
                        <td class="code">
                            <pre>
                                <span class="n">abc</span>
                                <span class="n">def</span>
                                <span class="w"></span>
                            </pre>
                        </td>
                    </tr>
                </tbody>
            </table>
    </pre>
</div>
<p>after</p>

Problem: code closed inside the table.

Resulting html for kramdown:

<p>before</p>
<div class="highlight">
    <pre>
        <code class="language-cs" data-lang="cs">
            <table style="border-spacing: 0">
                <tbody>
                    <tr>
                        <td class="gutter gl" style="text-align: right">
                            <pre class="lineno">
                            1
                            2
                            </pre>
                        </td>
                        <td class="code">
                            <pre>
                                <span class="n">abc</span>
                                <span class="n">def</span>
                                <span class="w"></span>
                            </pre>
                        </td>
                    </tr>
                </tbody>
            </table>
            after
        </code>
    </pre>
</div>

Problem: "after" inside highlighter div block, should be inside p after the block.

Reproduced with:

jekyll 2.1.1 and 2.2.0 (@phocks)
rouge 1.5.1

[parkr]

Interesting... no idea why this would be.

[phocks]

I can confirm this issue. I was going to create a new issue, but found this one. I was going to use 'rouge' as as my highlighter, but I need linenos, so looks like I'll have to stick with pygments. No worries.

[parkr]

Did it happen in Jekyll 2.1? #2676

[phocks]

I reproduced the invalid code with jekyll 2.2.0 running Ubuntu linux and tested it by creating a brand new 'jekyll new mysite' and editing the config...... I can maybe even have a look into why this is happening in the jekyll source when I get some free time later.

[parkr]

This seems to be a result of the weird mathn/classifier thing.

[parkr]

Re-open if Jekyll v2.3.0 doesn't solve your problem!

[aschamberger]

Still the same problem with v2.3.0.
With rouge and redcarpet the code tag is closed too early as described above.

[cdeil]

I also ran into this issue with jekyll 2.4.0.

[envygeeks]

It seems this was fixed with #3435 is this the case?

[aschamberger]

It's fixed.