Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple testcase for DEF parser #3

Open
nicolati opened this issue Feb 8, 2016 · 8 comments
Open

Simple testcase for DEF parser #3

nicolati opened this issue Feb 8, 2016 · 8 comments
Assignees

Comments

@nicolati
Copy link
Contributor

nicolati commented Feb 8, 2016

Hi Jeff,
I'm submitting a simple testcase for the DEF parser, extracted from a real testcase.
Actually the DEF parser is not able to parse it.
Another thing, the supported constructs depend obviously on the version specified in the DEF. This one is 5.6 .
test.def.zip

@jefftrull jefftrull self-assigned this Feb 24, 2016
@jefftrull
Copy link
Owner

This is very helpful, thank you. Real world DEF files are hard to find if you are not working directly in IC design.

@nicolati
Copy link
Contributor Author

Yeah, I know. You should support also for DEF the versioning, since commands change depending on it.

Fra

@jefftrull
Copy link
Owner

I have created a nicolati_bugs branch and am slowly implementing the necessary features to support the missing syntax there.

@nicolati
Copy link
Contributor Author

Very good! :)
I will keep checking! :)

Fra

@jefftrull
Copy link
Owner

I'm finally working on this again :)

I noticed that U265 and U267 are used in the NETS section but are not defined as components, which is supposed to be an error. I will make something up for now but if you want to supply an improved test case please feel free.

@nicolati
Copy link
Contributor Author

Hi Jeff,
I don't remember anymore which kind of DEF I have provided to you! :)
If the COMPONENTS section is totally missing, this is a valid DEF, but, if you don't instantiate the 2 missing components somehow (Verilog read, for instance), it has to be consider of course as error.

Fra

@jefftrull
Copy link
Owner

It is attached to your first message :) I improvised some additional components to satisfy the references. I can parse this DEF now, although not all the properties are stored. The nicolati_bugs branch has the new code. Can you try it?

@nicolati
Copy link
Contributor Author

Hi Jeff,
ok! Now I saw it! :)
As I said, it depends on the context.
If we are forcing the fact that the only component instantiator is the DEF, then you are right, the DEF is wrong. I modified it from a real one, since I cannot share real names, but I didn't think about that. Good catch! :)
Let me have some time to try it out.

Thank you,
Fra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants