Merge pull request #50 from Cheesebaron/feature/gh-49-overload-and-requiresunref-code-attrs

Add RequiresUnreferencedCode attribute for reflection code and add OverloadResolutionPriority attribute to prefer non-object methods

Author: jeffijoe

src/Jeffijoe.MessageFormat/Helpers/ObjectHelper.cs

@@ -5,6 +5,7 @@
 
 using System.Collections;
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
 using System.Linq;
 using System.Reflection;
 
@@ -26,6 +27,7 @@ internal static class ObjectHelper
     /// <returns>
     ///     The <see cref="IEnumerable" />.
     /// </returns>
+    [RequiresUnreferencedCode("This method uses reflection to read property information on object")]
     internal static IEnumerable<PropertyInfo> GetProperties(object obj)
     {
         var properties = new List<PropertyInfo>();
@@ -54,6 +56,7 @@ internal static IEnumerable<PropertyInfo> GetProperties(object obj)
     /// <returns>
     ///     The <see cref="IDictionary" />.
     /// </returns>
+    [RequiresUnreferencedCode("This method uses reflection to convert object into dictionary")]
     internal static Dictionary<string, object?> ToDictionary(this object obj)
     {
         // We want to be able to read the property, and it should not be an indexer.
@@ -69,4 +72,4 @@ internal static IEnumerable<PropertyInfo> GetProperties(object obj)
     }
 
     #endregion
-}
+}

src/Jeffijoe.MessageFormat/Jeffijoe.MessageFormat.csproj

@@ -4,13 +4,15 @@
     <SignAssembly>True</SignAssembly>
     <AssemblyOriginatorKeyFile>MessageFormat.snk</AssemblyOriginatorKeyFile>
     <PackageId>MessageFormat</PackageId>
-  	<GenerateAssemblyInfo>True</GenerateAssemblyInfo>
-  	<Authors>Jeff Hansen</Authors>
-  	<PackageTags>messageformat,messageformatter,xamarin,ui,messages,formatting,plural,pluralization,singular,select,strings,stringformat,format</PackageTags>
-  	<RepositoryUrl>https://github.com/jeffijoe/messageformat.net</RepositoryUrl>
-  	<LangVersion>latest</LangVersion>
-  	<Nullable>enable</Nullable>
-  	<TargetFrameworks>net6.0;net8.0;netstandard2.0;netstandard2.1</TargetFrameworks>
+    <GenerateAssemblyInfo>True</GenerateAssemblyInfo>
+    <Authors>Jeff Hansen</Authors>
+    <PackageTags>messageformat,messageformatter,xamarin,ui,messages,formatting,plural,pluralization,singular,select,strings,stringformat,format</PackageTags>
+    <RepositoryUrl>https://github.com/jeffijoe/messageformat.net</RepositoryUrl>
+    <LangVersion>latest</LangVersion>
+    <Nullable>enable</Nullable>
+    <TargetFrameworks>net6.0;net8.0;netstandard2.0;netstandard2.1</TargetFrameworks>
+    <PolySharpIncludeRuntimeSupportedAttributes>true</PolySharpIncludeRuntimeSupportedAttributes>
+    <IsTrimmable>true</IsTrimmable>
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
@@ -23,6 +25,10 @@
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
+    <PackageReference Include="PolySharp" Version="1.15.0">
+      <PrivateAssets>all</PrivateAssets>
+      <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
+    </PackageReference>
   </ItemGroup>
 
   <ItemGroup>

src/Jeffijoe.MessageFormat/MessageFormatter.cs

@@ -6,7 +6,9 @@
 using System;
 using System.Collections.Generic;
 using System.Collections.Concurrent;
+using System.Diagnostics.CodeAnalysis;
 using System.Linq;
+using System.Runtime.CompilerServices;
 using System.Text;
 using Jeffijoe.MessageFormat.Formatting;
 using Jeffijoe.MessageFormat.Formatting.Formatters;
@@ -202,6 +204,8 @@ public static string Format(string pattern, IReadOnlyDictionary<string, object?>
     /// <returns>
     ///     The formatted message.
     /// </returns>
+    [OverloadResolutionPriority(-1)]
+    [RequiresUnreferencedCode("This method uses the FormatMessage extension which uses reflection to convert object into dictionary")]
     public static string Format(string pattern, object data)
     {
         lock (Lock)
@@ -390,4 +394,4 @@ private IFormatterRequestCollection ParseRequests(string pattern, StringBuilder
     }
 
     #endregion
-}
+}

src/Jeffijoe.MessageFormat/MessageFormatterExtensions.cs

@@ -1,4 +1,6 @@
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
+using System.Runtime.CompilerServices;
 using Jeffijoe.MessageFormat.Helpers;
 
 namespace Jeffijoe.MessageFormat;
@@ -46,8 +48,10 @@ public static string FormatMessage(
     /// <returns>
     ///     The <see cref="string" />.
     /// </returns>
+    [OverloadResolutionPriority(-1)]
+    [RequiresUnreferencedCode("This method uses the ToDictionary extension which uses reflection to convert object into dictionary")]
     public static string FormatMessage(this IMessageFormatter formatter, string pattern, object args)
     {
         return formatter.FormatMessage(pattern, args.ToDictionary());
     }
-}
+}