Skip to content

Commit 6df9339

Browse files
Merge pull request git-for-windows#438: .github: continue pestering until user upgrades
In 'git-update-git-for-windows', there is a recently_seen variable that is loaded from Git config. This is intended to allow users to say "No, I don't want that version of Git for Windows." If users say no, then they are not reminded. Ever. We want users of microsoft/git to be notified repeately until they upgrade. The first notification might be dismissed because they don't want to interrupt their work. They should get the picture within a few reminders and upgrade in a timely fashion. --- I tested this by running the `sed` command in my copy of `git-for-windows/build-extra`, and then replacing my installed version of `git-update-git-for-windows` in `C:\Program Files\Git\mingw64\bin`. Along the way, I discovered a bug in the script and created git-for-windows/build-extra#382. If you do your own testing, you will likely need that fix, too. I also noticed a misplaced `&&` due to copying some existing scripts out of the workflow into a bash script so I could test all of the scripts simultaneously.
2 parents 041afb4 + 2cd09c0 commit 6df9339

File tree

1 file changed

+12
-2
lines changed

1 file changed

+12
-2
lines changed

.github/workflows/build-git-installers.yml

+12-2
Original file line numberDiff line numberDiff line change
@@ -190,17 +190,27 @@ jobs:
190190
b=/usr/src/build-extra &&
191191
192192
filename=$b/git-update-git-for-windows.config
193-
tr % '\t' >$filename <<-\EOF
193+
tr % '\t' >$filename <<-\EOF &&
194194
[update]
195195
%fromFork = microsoft/git
196-
EOF &&
196+
EOF
197197
198198
sed -i -e '/^#include "file-list.iss"/a\
199199
Source: {#SourcePath}\\..\\'$filename'; DestDir: {app}\\mingw64\\bin; Flags: replacesameversion; AfterInstall: DeleteFromVirtualStore' \
200200
-e '/^Type: dirifempty; Name: {app}\\{#MINGW_BITNESS}$/i\
201201
Type: files; Name: {app}\\{#MINGW_BITNESS}\\bin\\git-update-git-for-windows.config\
202202
Type: dirifempty; Name: {app}\\{#MINGW_BITNESS}\\bin' \
203203
$b/installer/install.iss
204+
- name: Set alerts to continue until upgrade is taken
205+
shell: bash
206+
run: |
207+
set -x
208+
209+
b=/usr/src/build-extra &&
210+
211+
sed -i -e \
212+
's/recently_seen="\$(get_recently_seen)"/recently_seen="bogus-to-keep-pestering"/' \
213+
$b/git-extra/git-update-git-for-windows
204214
- name: Set the installer Publisher to the Git Fundamentals team
205215
shell: bash
206216
run: |

0 commit comments

Comments
 (0)