feat(notification): support for multiple phone numbers

[benw25]

Description

Fixes #273.
Update to stale pull request #446

Multiple carriers & phone numbers are now supported in the .env file. Number of carriers must strictly match the number of phone numbers (documented in readme)

Error handling was changed a bit in sms.ts:

• if number of carriers does not match number of phones (even if one is 0), logger will warn
• if there is a difference in carrier.length or number.length, sendSms will say:

(carrier) is not associated with a number

or

(number) is not associated with a carrier

• phone.availableCarriers.has(carrier) has been moved to trigger a logging error inside of sendSms, and this logging function has been removed from generateAddress
• any of these above errors will continue and skip the rest of sendSms
• generateAddress now takes in a number and a carrier as arguments
• sendMail error callback now has the specific number & carrier to provide more info as to what happened

Misc changes were added to fix linting errors:

• max-params: 0 (unlimited) to account for xo linting showing an error in maxPrice in logger.ts. 5 is more than the apparent default of 4.
• because templating was added, I removed the backslash in the error logging for

couldn't send sms

Testing

• Tested multiple phone numbers & carriers (0 & 0, 1 & 1, 2 & 2), and mismatched combinations of the two (0 & 1, 1 & 0, ...etc.).
• Tested with carriers that do not match the list of availableCarriers (e.g. "goog")
• Tested with spaces in the envs, seems like this is already covered in the .trim in envOrArray
• All the above was run with npm run test:notification
• Ran the app with multiple numbers/carriers with no issues

[jef]

• max-params: 0 (unlimited) to account for xo linting showing an error in maxPrice in logger.ts. 5 is more than the apparent default of 4.

Maybe this could be something more reasonable like 10 for now? I'll change that in a later PR. Thanks for updating :)

[jef]

Great! I appreciate your work on fixing this. I really appreciate the help!

[jef]

Since we are doing the check on sizing in sms.ts:13-15, I'm not sure if this is needed.

[jef]

Oh, I see now. It's because it still allows the user to have misconfigured phone config.