fix: bestbuy label container selector precision #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's not any good. |
AdamSaketume26
pushed a commit
to AdamSaketume26/nvidia-snatcher
that referenced
this pull request
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Possibly fixes #488
I updated the label container selectors for both inStock and maxPrice to have better precision, beginning with [data-sticky-media-gallery]` to focus the search in the primary product offering on the page.
The previous container selectors allowed more elements to be selected on the page unintentionally, such as elements lower in the page in "Frequently bought together" and "Most-viewed sponsored products", which may have been a factor in issue #488
Testing
I tested the
bestbuystore to verify the test card shows "IN STOCK" and 30 series cards are all showing "OUT OF STOCK" as expected.New dependencies
N/A