Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add coolblue store #482

Merged
merged 6 commits into from
Oct 10, 2020
Merged

feat: add coolblue store #482

merged 6 commits into from
Oct 10, 2020

Conversation

FeikoWielsma
Copy link
Contributor

Description

Adds the Coolblue store since they seem to have stock sometimes since this morning.

Testing

I changed the URL into a 2060 to test, it seemed to work. I'm new to Javascript though (and pull requests in general), so let me know if I did anything weird!

@FeikoWielsma FeikoWielsma requested a review from jef as a code owner October 9, 2020 09:59
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things. Looks good otherwise!

src/store/model/coolblue.ts Outdated Show resolved Hide resolved
src/store/model/coolblue.ts Outdated Show resolved Hide resolved
src/store/model/coolblue.ts Outdated Show resolved Hide resolved
@FeikoWielsma FeikoWielsma requested a review from jef October 10, 2020 12:02
@jef
Copy link
Owner

jef commented Oct 10, 2020

Thank you!

@jef jef changed the title feat: add Coolblue store (NL) feat: add coolblue store Oct 10, 2020
@jef jef merged commit 5c61333 into jef:main Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants