Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker and .env quoting problems #1059

Closed
colemickens opened this issue Dec 1, 2020 · 4 comments
Closed

Docker and .env quoting problems #1059

colemickens opened this issue Dec 1, 2020 · 4 comments

Comments

@colemickens
Copy link

Description

Apparently, based on what just happened, the right thing does not happen if:

  • you actually start with the env example file, setting all of those values to blanks just causes headaches
  • the values are quoted

So,

  • better to only add what you need
  • don't quote the values in the env file (at least when using with docker)

I couldn't figure out what it was telling me "newegg" was invalid. Finally I tried "amazon,newegg,newegg-ca", got an error about "amazon and newegg-ca" and realized the problem

This worked, as an example, on the other hand, with the rest of the docker instructions that are there:

SHOW_ONLY_SERIES=ryzen5950,rx6800xt,sonyps5c,sonyps5de
STORES=amazon,newegg,newegg-ca

Possible solution

Slightly tweak the docker instructions, comment out the default blank values in env instead of leaving broken defaults as the example.

@mbafford
Copy link

mbafford commented Dec 3, 2020

Confirmed, I just had the same problems. Ultimately, the issue was quotes in .env. Once I removed all of the quotes from the .env file as with @colemickens example it works.

Removing the quotes fixed both the test notification path and the regular run path.

@jef jef removed their assignment Dec 8, 2020
@jef
Copy link
Owner

jef commented Dec 8, 2020

This is definitely the issue, unfortunately. I will keep this issue open until I make a fix.

Thanks!

@jef jef changed the title docker instructions don't work Docker and .env quoting problems Dec 8, 2020
@jef
Copy link
Owner

jef commented Dec 11, 2020

@jef
Copy link
Owner

jef commented Dec 11, 2020

Okay, I've pushed up a fix. I've removed all quotes from the dotenv-example. You all have a couple options here:

  • Remove all unused variables from dotenv
  • Remove all "

That being said, I pushed up a new nightly build. Feel free to try.

Also! You shouldn't have to use the --cap-add option anymore. Use this instead:

docker run -it --rm \
    --env-file ./dotenv \
    ghcr.io/jef/streetmerchant:nightly

Feel free to place dotenv with .env if you haven't migrated as it's backwards compatible.

Thanks!

@jef jef closed this as completed Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants