Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed lib subdirectory from package.json ref #26

Merged
merged 1 commit into from
Feb 24, 2017
Merged

removed lib subdirectory from package.json ref #26

merged 1 commit into from
Feb 24, 2017

Conversation

zwerdlds
Copy link
Contributor

Hi,
I encountered an issue where my runtime requires weren't finding the plugin.js file.

Node was looking to postcss-nested-props/dist/lib/plugin.js as per the package.json, but the actual installed location was postcss-nested-props/dist/plugin.js.

I attempted various other machine-specific fixes:

reinitialized the containing docker container
removing and reinstalling my node_modules in the application
Neither of these resolved the issue.

I am unsure why there hasn't been any other noise on this, and I am additionally confused as my configuration was working not three days ago without the below modification.

This modification resolves this issue by pointing the main and types parameters to the appropriate issue. After this modification, node require can successfully find the plugin.js file.

Thank you for this project. Please let me know if I am errant in anything including the premise of this PR.

removed lib subdirectory from package.json ref from NPM package referenced main and types params.
@codecov
Copy link

codecov bot commented Feb 24, 2017

Codecov Report

Merging #26 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #26   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          37     37           
  Branches        5      5           
=====================================
  Hits           37     37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70f87fd...01e21dd. Read the comment docs.

@jednano
Copy link
Owner

jednano commented Feb 24, 2017

Thanks! I'll get this in right away. I had been reorganizing some file structure and missed this spot. Sorry!

@jednano jednano merged commit 0e08228 into jednano:master Feb 24, 2017
@jednano
Copy link
Owner

jednano commented Feb 24, 2017

Published @ v1.1.7.

@zwerdlds zwerdlds deleted the lib-subdirectory-removal branch March 7, 2017 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants