Skip to content
This repository has been archived by the owner on Dec 10, 2019. It is now read-only.

Migrate panel to dock #159

Closed
netizen-ais opened this issue Jun 26, 2017 · 9 comments
Closed

Migrate panel to dock #159

netizen-ais opened this issue Jun 26, 2017 · 9 comments

Comments

@netizen-ais
Copy link

It would be really great to have the project viewer integrated in the left dock as a tab. Wouldn't it?

@jccguimaraes
Copy link
Owner

there is work in progress around that, i think there is a config to make it a dock but it's pretty unstable

@jccguimaraes
Copy link
Owner

it's commented in the code, you can't change right now. sorry

@jccguimaraes jccguimaraes added this to the 1.3.0 milestone Jun 26, 2017
@netizen-ais
Copy link
Author

netizen-ais commented Jun 26, 2017

Well, I've just activated the needed lines and asides from a little empty space it works nice!

Edit: Fixed with:
.pane { project-viewer { width: 100%; } }

@jccguimaraes
Copy link
Owner

@RGawenda cool! If you give it a go and see if no bugs arise. Care to make a MR?

@netizen-ais
Copy link
Author

I'm not really sure how to make a MR yet, but I can make a diff to see which lines I uncommented, some of them where blocking the package loading because a missing )

@jccguimaraes
Copy link
Owner

did you fork the project?

@netizen-ais
Copy link
Author

I've just done it, but forgot to create a branch. Quite new to git/guthub 😁

@jccguimaraes
Copy link
Owner

thanks @RGawenda i am not finding time yet to review this sorry. Hope in a couple of days have.

Thank you so much for the PR by the way!

@jccguimaraes
Copy link
Owner

closing as this will be to the next major version.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants