Error when creating a node without selecting a node type

[Hammster]

When creating a new node and no type is selected you can still press Create, which creates a error.

This should be handled or the Type selection radio should have a default selected. Also a little UX improvement 💪

[jccguimaraes]

did this help out?

atom-project-viewer/src/editor-view.js

Line 652 in 929623e

if (!type) { return false; }

[Hammster]

Yep, but UX wise defaulting would be better. Or at least provide a small alert, so that the user knows what he forgot to set.

[jccguimaraes]

so you think it's best to make it default like to project?

[Hammster]

correct. then you have one click less for the default scenario.
Btw did you not had create project and create group in the context menu? Was there a reason to add the layer of the interface in between there? Or did you plan future use of the pane for a later expansion?

Sorry if I am bit nitpicky here 😸

[jccguimaraes]

hey @Hammster, sorry for late implementation. It's done now.

I didn't understand the last part "Was there..."

[Hammster]

Currently the steps are as followed

Right Click -> Create New -> Select the Type -> Fill Information -> Create

Before it was a little bit shorter

Right Click -> Create "Type" -> Fill Information -> Create

Was there a reason to do this ?

[jccguimaraes]

solo option for not having 2 menu items instead of just one... :D

[Hammster]

UX wise i would prefere to have two options, it feels a little bit artificial :P Also no worries for the late responses, i am also stuck in a pile of work 🔨

[jccguimaraes]

will try to add both then

[jccguimaraes]

done! will ship on next release. Taking the time to close some others I hope

[jccguimaraes]

please validate this issue!

[Hammster]

Great work, nothing to complain about 😄👍