-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes and updates #15
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplified result checking
Added param to return metadata as object
Fix bug for director
added doc for getAccount
@jc21 Hey, just curious if there is anything else you'd like from me to pull this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the fixes that delovelady asked about in issue #13 & #14 . Also, added parsing for Music libraries. Photo libraries are going to need a lot of thought before implementing that. Lastly, fixed some other various bugs and added PHPUnit and Dotenv for dev unit testing.
I also added a call to the
/myplex/account
that was asked for in #11 . #8 should also be fixed because I never saw the issue in my testing. I also added delovelady's code snippet in his last comment.To do unit tests, update to this version, then run
composer test
. The setup method will check your environment variables and tell you want to do next. I set up a.env
file in the tests directory that looks like this.