Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclusive=x flag and RemoteRepository #227

Open
ThomasWaldmann opened this issue Mar 9, 2015 · 0 comments
Open

exclusive=x flag and RemoteRepository #227

ThomasWaldmann opened this issue Mar 9, 2015 · 0 comments

Comments

@ThomasWaldmann
Copy link
Contributor

ThomasWaldmann commented Mar 9, 2015

The server dispatcher calls RepositoryServer.open(path, create). The method signature does not support a "exclusive" flag. Slightly confusing: the signature of Repository.open(path, exclusive) which has a different value at same position.

From RepositoryServer.open, it calls Repository(path, create) without giving exclusive=x. This means that the repository is (initially) not exclusively locked in the case of remote repositories. Later, in first call to prepare_txn, the shared lock will be upgraded to an exclusive lock.

Just wondering why local and remote repos are handled in that way. Some documentation about attic's locking rules / ideas behind the locking procedures would be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant