Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

OTel RC1 is fubar #6

Closed
buvinghausen opened this issue Nov 19, 2020 · 5 comments
Closed

OTel RC1 is fubar #6

buvinghausen opened this issue Nov 19, 2020 · 5 comments

Comments

@buvinghausen
Copy link

open-telemetry/opentelemetry-dotnet#1580

They went and made ActivitySourceAdapter, DiagnosticSourceSubscriber, & ListenerHandler all internal. It broke not only this instrumentation provider but all the ones in their dotnet contrib project. The best part was they didn't provide any guidance on how to work around the new accessibility level restrictions.

Not calling it out here because I want you to take action just calling it out to make sure there is awareness.

@jbogard
Copy link
Owner

jbogard commented Nov 20, 2020

Ruh roh.

@buvinghausen
Copy link
Author

buvinghausen commented Nov 20, 2020

@jbogard I'm advocating they move DiagnosticSourceSubscriber & ListenerHandler to a separate package like OpenTelemetry.Instrumentation.Abstractions and restore the public accessiblity.

They have that thread going on for what to do about the ActivitySourceAdapter so I will let that run it's course.

First step is opening a PR on their end to allow .NET 5.0 to host the package in OpenTelemetry.Extensions.Hosting #babysteps

@buvinghausen
Copy link
Author

Ahh they have moved the upper band up to v6 in the RC but then broke everything else LOL

@buvinghausen
Copy link
Author

Over the holiday weekend I'm going to take a stab at reconciling the difference in how they did the StackExchange.Redis instrumentation (which doesn't use any of the internals) and both of your libraries. I'll let you know what I find out but if I can log the appropriate activities into cloudwatch I'll open some PRs to discuss.

@jbogard
Copy link
Owner

jbogard commented Nov 30, 2020

I've pushed out a new package for this and the base library.

@jbogard jbogard closed this as completed Nov 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants