From bc8da3ddd59753aa4b7703be37fe58d3e12087db Mon Sep 17 00:00:00 2001 From: Nagico Date: Wed, 28 Dec 2022 00:55:34 +0800 Subject: [PATCH] Add invalid port exception --- dj_database_url.py | 2 +- test_dj_database_url.py | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/dj_database_url.py b/dj_database_url.py index 375c321..55959a2 100644 --- a/dj_database_url.py +++ b/dj_database_url.py @@ -165,7 +165,7 @@ def parse( if engine == "djongo": # compatible with multiple host:port port = None else: - raise e + raise ValueError(f'Port parse error: {e}') # Update with environment configuration. parsed_config.update( diff --git a/test_dj_database_url.py b/test_dj_database_url.py index 0371e31..8f38df4 100644 --- a/test_dj_database_url.py +++ b/test_dj_database_url.py @@ -653,6 +653,10 @@ def test_bad_url_parsing(self): with self.assertRaisesRegex(ValueError, "No support for 'foo'. We support: "): dj_database_url.parse("foo://bar") + def test_bad_port_parsing(self): + with self.assertRaisesRegex(Exception, "Port parse error"): + dj_database_url.parse("mysql://foo:bar@localhost:65536/db") + if __name__ == "__main__": unittest.main()